When opening O_DIRECT, tell the kernel to invalidate its cache

This commit is contained in:
Brian Tarricone 2024-10-23 03:07:14 -07:00
parent 896545333b
commit 2e4934e986
2 changed files with 11 additions and 10 deletions

View File

@ -21,6 +21,7 @@ To test from the cmdline:
echo "hello world" > ~/corrupt-fs/hello.txt echo "hello world" > ~/corrupt-fs/hello.txt
cat ~/corrupt-fs/hello.txt # returns good data from fscache cat ~/corrupt-fs/hello.txt # returns good data from fscache
dd if=~/corrupt-fs/hello.txt iflag=direct # returns bad data dd if=~/corrupt-fs/hello.txt iflag=direct # returns bad data
cat ~/corrupt-fs/hello.txt # returns bad data
``` ```
Limitations: Limitations:

View File

@ -260,11 +260,11 @@ impl Filesystem for CorruptFs {
let open_file = OpenFile { ino, flags }; let open_file = OpenFile { ino, flags };
self.open_fds.insert(fh, OpenFd::File(open_file)); self.open_fds.insert(fh, OpenFd::File(open_file));
let mut o_flags = FOPEN_KEEP_CACHE; let o_flags = if (flags & O_DIRECT) != 0 {
if (flags & O_DIRECT) != 0 { FOPEN_DIRECT_IO
o_flags |= FOPEN_DIRECT_IO; } else {
} FOPEN_KEEP_CACHE
};
reply.opened(fh, o_flags); reply.opened(fh, o_flags);
} else { } else {
reply.error(ENOENT); reply.error(ENOENT);
@ -311,11 +311,11 @@ impl Filesystem for CorruptFs {
}; };
self.open_fds.insert(fh, OpenFd::File(open_file)); self.open_fds.insert(fh, OpenFd::File(open_file));
let mut cr_flags = FOPEN_KEEP_CACHE; let cr_flags = if (flags & O_DIRECT) != 0 {
if (flags & O_DIRECT) != 0 { FOPEN_DIRECT_IO
cr_flags |= FOPEN_DIRECT_IO; } else {
} FOPEN_KEEP_CACHE
};
reply.created(&TTL, &attr, 0, fh, cr_flags); reply.created(&TTL, &attr, 0, fh, cr_flags);
} }
} }