Return reasonable response if unsupported event type
This commit is contained in:
parent
59d4123321
commit
8e72bedcf1
@ -202,6 +202,8 @@ pub enum GitlabEvent {
|
||||
user: User,
|
||||
project: Project,
|
||||
},
|
||||
#[serde(other)]
|
||||
Other,
|
||||
}
|
||||
|
||||
impl GitlabEventExt for GitlabEvent {
|
||||
@ -212,6 +214,7 @@ impl GitlabEventExt for GitlabEvent {
|
||||
GitlabEvent::Issue { project, .. } => project,
|
||||
GitlabEvent::MergeRequest { project, .. } => &project,
|
||||
GitlabEvent::Pipeline { project, .. } => &project,
|
||||
GitlabEvent::Other => unreachable!("Unsupported event type"),
|
||||
}
|
||||
}
|
||||
|
||||
@ -222,6 +225,7 @@ impl GitlabEventExt for GitlabEvent {
|
||||
GitlabEvent::Issue { .. } => None,
|
||||
GitlabEvent::MergeRequest { object_attributes, .. } => Some(&object_attributes.target_branch),
|
||||
GitlabEvent::Pipeline { object_attributes, .. } => Some(&object_attributes.r#ref),
|
||||
GitlabEvent::Other => unreachable!("Unsupported event type"),
|
||||
}
|
||||
}
|
||||
|
||||
@ -232,6 +236,7 @@ impl GitlabEventExt for GitlabEvent {
|
||||
GitlabEvent::Issue { user, .. } => &user.name,
|
||||
GitlabEvent::MergeRequest { user, .. } => &user.name,
|
||||
GitlabEvent::Pipeline { user, .. } => &user.name,
|
||||
GitlabEvent::Other => unreachable!("Unsupported event type"),
|
||||
}
|
||||
}
|
||||
|
||||
@ -329,6 +334,7 @@ impl GitlabEventExt for GitlabEvent {
|
||||
vec![]
|
||||
}
|
||||
}
|
||||
GitlabEvent::Other => unreachable!("Unsupported event type"),
|
||||
}
|
||||
}
|
||||
}
|
||||
|
12
src/main.rs
12
src/main.rs
@ -185,6 +185,11 @@ async fn run() -> anyhow::Result<()> {
|
||||
let event_tx = event_tx.clone();
|
||||
|
||||
async move {
|
||||
match event {
|
||||
GitlabEvent::Other => {
|
||||
warp::reply::with_status("Unsupported Gitlab event type", StatusCode::BAD_REQUEST)
|
||||
}
|
||||
_ => {
|
||||
let project = event.project();
|
||||
let config_key = project.web_url.replace("http://", "").replace("https://", "");
|
||||
if let Some(repo_config) = config.repo_configs.get(&config_key) {
|
||||
@ -200,7 +205,10 @@ async fn run() -> anyhow::Result<()> {
|
||||
warp::reply::with_status("OK", StatusCode::OK)
|
||||
} else {
|
||||
info!("Channel not configured for repo '{}'", config_key);
|
||||
warp::reply::with_status("Matrix room not configured for repo", StatusCode::NOT_FOUND)
|
||||
warp::reply::with_status(
|
||||
"Matrix room not configured for repo",
|
||||
StatusCode::NOT_FOUND,
|
||||
)
|
||||
}
|
||||
}
|
||||
} else {
|
||||
@ -208,6 +216,8 @@ async fn run() -> anyhow::Result<()> {
|
||||
warp::reply::with_status("Repo not configured", StatusCode::NOT_FOUND)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
let routes = gitlab.with(warp::log("bebot"));
|
||||
|
Loading…
x
Reference in New Issue
Block a user